Skip to content

Popover - minor prop updates #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Popover - minor prop updates #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/components/popover/Popover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ const Popover = props => {
};

Popover.defaultProps = {
delay: {show: 0, hide: 50}
delay: {show: 0, hide: 50},
placement: 'right',
flip: true
};

Popover.propTypes = {
Expand Down Expand Up @@ -110,11 +112,6 @@ Popover.propTypes = {
*/
target: PropTypes.string,

/**
* Where to inject the popper DOM node, default body.
*/
container: PropTypes.string,

/**
* Space separated list of triggers (e.g. "click hover focus legacy"). These
* specify ways in which the target component can toggle the popover. If not
Expand Down Expand Up @@ -152,15 +149,15 @@ Popover.propTypes = {
innerClassName: PropTypes.string,

/**
* Optionally override show/hide delays - default {show: 0, hide: 250}
* Optionally override show/hide delays
*/
delay: PropTypes.oneOfType([
PropTypes.shape({show: PropTypes.number, hide: PropTypes.number}),
PropTypes.number
]),

/**
* Popover offset.
* Offset of the popover relative to its target
*/
offset: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),

Expand Down