Radio button doc example #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsdown
force-pushed
the
radio-button-doc-example
branch
2 times, most recently
from
1513733 to
440cc37
Compare
glsdown
force-pushed
the
radio-button-doc-example
branch
from
440cc37 to
19236e5
Compare
glsdown
force-pushed
the
radio-button-doc-example
branch
from
a44df8f to
417c59d
Compare
tcbegley
requested changes
Aug 30, 2021
Collaborator
tcbegley
left a comment
tcbegley
left a comment
There was a problem hiding this comment.
Thanks! Just a few minor comments inline.
glsdown
force-pushed
the
radio-button-doc-example
branch
from
8da8d35 to
417c59d
Compare
Co-authored-by: Tom Begley <tomcbegley@gmail.com>
tcbegley
added a commit
that referenced
this pull request
Sep 5, 2021
* Fixed button group radio doc example * Add input checked style and class_name * Changed colour to primary * Apply suggestions from code review Co-authored-by: Tom Begley <tomcbegley@gmail.com> * Reposition CSS in buttongroup examples Co-authored-by: Tom Begley <tomcbegley@gmail.com>
tcbegley
added a commit
that referenced
this pull request
Oct 19, 2021
* Fixed button group radio doc example * Add input checked style and class_name * Changed colour to primary * Apply suggestions from code review Co-authored-by: Tom Begley <tomcbegley@gmail.com> * Reposition CSS in buttongroup examples Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #651 in v1 docs, there were issues with styling of the radio example in ButtonGroup docs. I have fixed this using the new class name for this purpose in the Bootstrap 5 docs. This simplified the CSS required.
When fixing it, I noticed a similar issue with the custom checked formatting example in input, so I have added some new props to the checklist and radioitems components to allow you to easily change the checked styles, without having to resort to custom CSS.