Dropdown bug fixing #662
Merged
Dropdown bug fixing #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Solved the issue with the dropdown not appearing until scrolled - I was using an old library. A clean reinstall fixed the issue. |
tcbegley
reviewed
Sep 1, 2021
|
|
||
| {{example:components/dropdown/content.py:dropdown}} | ||
|
|
||
| ## AutoClose |
Collaborator
There was a problem hiding this comment.
This property doesn't appear to be working.
Fixing it will likely introduce a breaking change because currently dismissal of the dropdown menu is controlled by the toggle prop of each DropdownMenuItem.
I think the auto_close interface is nicer, but not backwards compatible so... 🤷♂️
tcbegley
approved these changes
Sep 1, 2021
tcbegley
added a commit
that referenced
this pull request
Sep 5, 2021
* Updated to use react-bootstrap props * Update dropdown alignment examples * Add dropdown autoclose examples * Add dark dropdown examples * Update dropdown direction examples * Update dropdown docs for new/amended examples * Format * Fixed dropdown in button group * Remove new auto_close prop in dropdown Co-authored-by: tcbegley <tomcbegley@gmail.com>
tcbegley
added a commit
that referenced
this pull request
Oct 19, 2021
* Updated to use react-bootstrap props * Update dropdown alignment examples * Add dropdown autoclose examples * Add dark dropdown examples * Update dropdown direction examples * Update dropdown docs for new/amended examples * Format * Fixed dropdown in button group * Remove new auto_close prop in dropdown Co-authored-by: tcbegley <tomcbegley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of bugs were identified in #651 about the dropdown. I have fixed a number of them where the props changed in the move to react-bootstrap and these are now working. However, there is a fundamental issue with the component I am unable to solve which means that the menu doesn't appear until the mouse is scrolled. Once this has been fixed, then the other issues, including those relating to the nav drop downs, should also be fixed.