Allow dict ids as target id for Tooltip #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcbegley
requested changes
Sep 16, 2021
Collaborator
tcbegley
left a comment
tcbegley
left a comment
There was a problem hiding this comment.
Nice! So great that this is working now. I swear I tried something like this with the old reactstrap implementation and it didn't like it... Anyway, not going to complain 😅
Can you:
- Move
stringifyIdintoOverlay.js, then we save ourselves some duplication. - Add an integration test in
tests/ - Delete the work-around from
faq.mdin the docs.
Contributor
Author
|
Great - I'm glad you like it. 😺 I learned how to do that when I did the PR to add the Clipboard component to I'll start working on your other requests. |
tcbegley
added a commit
that referenced
this pull request
Oct 19, 2021
* Allow dict ids as target id for Tooltip * Included Popover too * update based on review Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the Tooltip target to include IDs that are dictionaries - like those used in pattern matching callbacks.