Tomcat 8 MixedAuthenticator bug

[rripley]

For the Tomcat 8 MixedAuthenticator, a dummy LoginConfig object was being created and used instead of pulling LoginConfig out of the context.

[hazendaz]

Really good catch! Thank you for the contribution.

[dblock]

I encourage everyone to write tests for this kind of stuff!

[hazendaz]

Sure. Makes perfect sense. In this case I did the original coding there. It was an api change in tomcat. I clearly dropped the original ball and appeared to have taken test code to create that object. I'll add some documentation for contributors if we don't have this as a requirement and I will not accept in future without test cases. Thanks for pointing this out.

--- Original Message ---

From: "Daniel Doubrovkine (dB.) @dblockdotorg" notifications@github.com
Sent: January 22, 2015 7:14 AM
To: "dblock/waffle" waffle@noreply.github.com
Cc: "Jeremy Landis" jeremylandis@hotmail.com
Subject: Re: [waffle] Tomcat 8 MixedAuthenticator bug (#192)

I encourage everyone to write tests for this kind of stuff!

---

Reply to this email directly or view it on GitHub:
#192 (comment)