Don't allow SPNEGO NegTokenArg to start re-authentication.#338
Merged
dblock merged 1 commit intoWaffle:masterfrom Apr 7, 2016
ASunc:fix-issue-167-part1
Merged
Don't allow SPNEGO NegTokenArg to start re-authentication.#338dblock merged 1 commit intoWaffle:masterfrom ASunc:fix-issue-167-part1
dblock merged 1 commit intoWaffle:masterfrom
ASunc:fix-issue-167-part1
Conversation
Collaborator
|
Very good. Amend CHANGELOG please? |
Collaborator
Author
|
Added entry to CHANGELOG. |
| 1.8.2 (?/??/16) | ||
| ================ | ||
|
|
||
| * [#338](https://github.com/dblock/waffle/pull/338): Don't allow SPNEGO NegTokenArg to start re-authentication process. |
Collaborator
There was a problem hiding this comment.
Amend with your name, see other lines.
This was referenced May 2, 2016
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only NegTokenInit is similar to NTLM type 1 message, NegTokenArg occurs only when there is already an ongoing negotiation. Cleaned up method names a bit also to reflect this.
This should fix the first problem in issue #167.