feat(config): re-introduce noSourceMap option, cleanup

Author: dbo

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016 Daniel Bölzle
+Copyright (c) 2018 Daniel Bölzle
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -26,6 +26,7 @@ $ babel --plugins babel-plugin-transform-n4js-systemjs-commonjs ...
 Plugin Options:
 - `verbose: [string]` switches on verbose logging of the used module IDs
 - `stripPackageID_re: [string|Regexp]` regex to rewrite/strip parts of the package ID by convention
+- `noSourceMap: [boolean]` whether the N4JS source-map reference should be dropped; defaults to `true`
 
 ## License
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "babel-plugin-transform-n4js-systemjs-commonjs",
   "description": "A babel plugin to transform N4JS SystemJS modules into CommonJS, enabling webpack (via babel-loader) or react-native packager.",
-  "main": "sysreg.js",
+  "main": "transform-n4js-systemjs-commonjs.js",
   "scripts": {
     "test": "eslint . && mocha tests",
     "semantic-release": "semantic-release",
@@ -11,7 +11,7 @@
     "node": ">=6.4.0"
   },
   "files": [
-    "index.js"
+    "transform-n4js-systemjs-commonjs.js"
   ],
   "keywords": [
     "n4js",

tests/test.js

@@ -11,7 +11,7 @@ const path = p => lib_path.resolve(__dirname, ...p.split("/"));
 const read = p => String(lib_fs.readFileSync(path(p)));
 
 const babelOptions = {
-    plugins: [[path("../index.js"), {
+    plugins: [[path("../transform-n4js-systemjs-commonjs.js"), {
         //verbose: true,
         stripPackageID_re: "\\.api$"
     }]]
@@ -29,7 +29,7 @@ describe("N4JS SystemJS -> CommonJS", () => {
     it("transforms System.registerDynamic", () => fixtureTest("data/dummy/regdyn"));
 
     it("keeps non-N4JS modules as is", () => {
-        const pluginCode = read("../index.js");
+        const pluginCode = read("../transform-n4js-systemjs-commonjs.js");
         const expected = babel.transformSync(pluginCode).code;
         const res = babel.transformSync(pluginCode, babelOptions).code;
         assert.equal(res, expected, "should be the same output");

index.js renamed to transform-n4js-systemjs-commonjs.js

@@ -91,8 +91,12 @@ module.exports = ({types: t}) => {
                 let program = path.node,
                     opts = state.opts || {},
                     verbose = opts.verbose,
-                    stripPackageID_re = opts.stripPackageID_re;
+                    stripPackageID_re = opts.stripPackageID_re,
+                    noSourceMap = opts.noSourceMap;
 
+                if (typeof noSourceMap === "undefined") {
+                    noSourceMap = true;
+                }
                 if (stripPackageID_re && !(stripPackageID_re instanceof RegExp)) {
                     stripPackageID_re = new RegExp(stripPackageID_re);
                 }
@@ -124,6 +128,15 @@ module.exports = ({types: t}) => {
                             sysRegExpr.arguments.push(t.stringLiteral(getModuleIdOf(filename, verbose)));
                         }
 
+                        if (noSourceMap) {
+                            const comments = path.container.comments;
+                            comments.forEach(c => {
+                                if (c.value.startsWith("# sourceMappingURL=")) {
+                                    c.value = `--${c.value}--`;
+                                }
+                            });
+                        }
+
                         // replace all System._nodeRequire calls
                         path.traverse(_nodeRequireVisitor);