Skip to content

Support kv db url #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 77 commits into from
Nov 12, 2025
Merged

Support kv db url #181

merged 77 commits into from
Nov 12, 2025

Conversation

@maxdml
Copy link
Collaborator

@maxdml maxdml commented Nov 6, 2025 •
edited
Loading

Postgres / libpq accepts connection strings in a key value format.

Today we already support this transparently in the SDK.

But we don't mask passwords well when these are passed.

The CLI doesn't support this format.

This PR:

  • Add some logic to mask passwords when printing the connection parameters
  • Fix the CLI to allow these strings.

addresses #172

maxdml added 30 commits October 29, 2025 14:16
@maxdml
just call deserialized during dequeue
318bb8e
@maxdml
decode during recovery (instead of getting it decoded from list workf…
0259dd6 
…lows
@maxdml
lift encoding outside of the system db
bf35e78
@maxdml
encode in enqueue, client
9852279
@maxdml
fix
f945e3b
@maxdml
decode on the concurrent execution fallback path
ecad764
@maxdml
system db expects pointers to string, correctly set in serialize()
16f6aea
@maxdml
not now
f05d0c9
@maxdml
fix + awaitWorkflowResult returns *string
a3bd6f7
@maxdml
fixes
7c8211a
@maxdml
nit
e87d0e6
@maxdml
custom serializer
ab20c6a
@maxdml
wip
2ae4129
@maxdml
comment
687842e
@maxdml
udpate test
0646fcf
@maxdml
test recovery path. Add JSON recast in wrapped functions and in step …
9e5fb44 
…output
@maxdml
qeueue decode + test
0700203
@maxdml
wip interfaces
7b96377
@maxdml
wip
550cd76
@maxdml
remove Gob encoder
8c08963
@maxdml
simplify tests and extend coverage
e5844c9
@maxdml
test concrete signatures, test more send/recv set/get messages
7950464
@maxdml
update tests
c48821f
@maxdml
fix
8bd98fc
@maxdml
comments
ae0f005
@maxdml
comment
0d9df4e
@maxdml
cleanup
03cb9a4
@maxdml
fix
9e7be97
@maxdml
comments
ad5fe3c
@maxdml
Merge remote-tracking branch 'origin/lift-serialization-to-typed-laye…
38c4ff7 
…r' into custom-serializer

# Conflicts:
#	dbos/queue.go
#	dbos/recovery.go
#	dbos/serialization.go
#	dbos/system_database.go
#	dbos/workflow.go
maxdml added 20 commits November 3, 2025 15:57
@maxdml
cleanup
8d74304
@maxdml
more complex struct
800c0ed
@maxdml
shouldn't require user gob registration
9676054
@maxdml
no interface signature
14f73be
@maxdml
cleanup
31ebaee
@maxdml
cleanup
ccb51f6
@maxdml
make the serializer generic to tighten the code, add a test with manu…
a05aead 
…al registration for gob interface
@maxdml
cleanup + add pointer fields to test struct
439a92c
@maxdml
consolidate tests and always exercise recovery path
61f727d
@maxdml
cannot store child 'steps' as nil in the db to run as step
1a6a950
@maxdml
test some more signatures
370d33e
@maxdml
fix
de6488a
@maxdml
nits
5443e4f
@maxdml
internal stepInfo with *string step output
219a647
@maxdml
detect nested pointers during wf registration and running steps
eb4371a
@maxdml
fix flaky test that more than flaky
85b37cf
@maxdml
fix another race in test
e163953
@maxdml
mask password in kv urls and add some tests
383211b
@maxdml
handle k/v urls format in the CLI
17597b1
@maxdml
test
73217a5
@maxdml maxdml changed the base branch from main to custom-serializer November 6, 2025 00:58
@maxdml maxdml marked this pull request as ready for review November 11, 2025 23:35
@maxdml maxdml changed the base branch from custom-serializer to main November 11, 2025 23:40
@maxdml maxdml merged commit 4e8fb10 into main Nov 12, 2025
3 checks passed
@maxdml maxdml deleted the support-kv-db-url branch November 12, 2025 00:33
@maxdml maxdml mentioned this pull request Nov 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftp kraftp kraftp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxdml @kraftp