Fix destroy for asyncio #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related Documentation Checked 4 published document(s). No updates required. How did I do? Any feedback? |
|
Documentation updates Checked 4 published document(s). No updates required. How did I do? Any feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
DBOS.destroy()shuts down the executor pool but leaves it attached to the event loop. As a result, if DBOS is re-initialized and async functions are invoked directly, the loop still tries to use the destroyed pool and raises a runtime error.The fix is to let the wrapper functions optionally accept a
dbosinstance. This makes sure the event loop is always configured correctly, even when async workflows are called directly after re-initialization.Added a test for destroy semantics for asyncio.