Add support for React keys via a uniqueKey prop #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to create a prop named `key` without getting errors, and I didn't want to pass arbitrary props into the component, so I named the prop`uniqueKey`. This also vastly simplifies how common props can be passed into `SecureLink` by extending the `React.HTMLAttributes<HTMLAnchorElement>` interface which has the props (in addition to many others), that I was manually defining (`className` and `style`).
|
Coverage after merging AddKey into main
Coverage Report
|
|||||||||||||||||||||||||||||||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to create a prop named
keywithout getting errors, and I didn't want to pass arbitrary props into the component, so I named the propuniqueKey.This also vastly simplifies how common props can be passed into
SecureLinkby extending theReact.HTMLAttributes<HTMLAnchorElement>interface which has the props (in addition to many others), that I was manually defining (classNameandstyle).