Add parameter W to allow scaling fan speed between min and max#258
Closed
wilriker wants to merge 1 commit intoDuet3D:devfrom
Closed
Add parameter W to allow scaling fan speed between min and max#258wilriker wants to merge 1 commit intoDuet3D:devfrom
wilriker wants to merge 1 commit intoDuet3D:devfrom
Conversation
…d of being absolute
Contributor
Author
|
You implemented it yourself so I am closing this one. |
abates-dentsu
pushed a commit
to abates-dentsu/RepRapFirmware
that referenced
this pull request
Oct 1, 2021
…socket-extensions-0.1.4 Build(deps): Bump websocket-extensions from 0.1.3 to 0.1.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new option would give a choice to the user to have the speed being set as absolute or scaled between min and max as discussed in: https://forum.duet3d.com/topic/8864/m106-maximum-fan-speed-setting-unproportional
You did not respond to whether this OK or not. So as usual just reject it if you think it is not worth or a good idea adding. ;-)