Fix for Int when used as key, only gen when needed
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used as a key `Int` requires more traits, which can't be auto-generated when used as a tuple enum. This switches it to a named enum any ignores encoding fields for those traits. This also stops duplicate keys which were possible previously when the encoding differed. We now only generate `Int` when it is actually referenced within the CDDL definitions being generated.
Collaborator
Author
|
I'm just going to merge this now since it's a minor change and likely wouldn't be reviewed for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used as a key
Intrequires more traits, which can't be auto-generated when used as a tuple enum. This switches it to a named enum any ignores encoding fields for those traits. This also stops duplicate keys which were possible previously when the encoding differed.We now only generate
Intwhen it is actually referenced within the CDDL definitions being generated.