Skip to content

Conversation

@kwedrowicz
Copy link
Contributor

First of all, thanks @pilloPl for great DDD example in practice 💪

During the project study, I found that not all tests are passing (which brokes CI). Guilty was double wrapping in HATEOAS compatible classes in PatronProfileController.

Actual patronProfile endpoint result:

{
  "entity": {
    "_links": {
      "holds": {
        "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/holds/"
      },
      "checkouts": {
        "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/checkouts/"
      },
      "self": {
        "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd"
      }
    },
    "patronId": "d969e595-1bc2-40ec-996c-90c6a396a3bd"
  }
}

Expected result:

{
  "_links": {
    "holds": {
      "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/holds/"
    },
    "checkouts": {
      "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/checkouts/"
    },
    "self": {
      "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd"
    }
  },
  "patronId": "d969e595-1bc2-40ec-996c-90c6a396a3bd"
}

Small fix applied 😄

@pilloPl
Copy link
Member

pilloPl commented Sep 26, 2019

Thank you so much!

@pilloPl pilloPl merged commit 421ef2d into ddd-by-examples:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants