[FIX] Hateoas consistency and tests fixes #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks @pilloPl for great DDD example in practice 💪
During the project study, I found that not all tests are passing (which brokes CI). Guilty was double wrapping in HATEOAS compatible classes in
PatronProfileController.Actual
patronProfileendpoint result:{ "entity": { "_links": { "holds": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/holds/" }, "checkouts": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/checkouts/" }, "self": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd" } }, "patronId": "d969e595-1bc2-40ec-996c-90c6a396a3bd" } }Expected result:
{ "_links": { "holds": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/holds/" }, "checkouts": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd/checkouts/" }, "self": { "href": "http://localhost:8080/profiles/d969e595-1bc2-40ec-996c-90c6a396a3bd" } }, "patronId": "d969e595-1bc2-40ec-996c-90c6a396a3bd" }Small fix applied 😄