Plugins are not working with current adminer

[aneufeld23]

Preliminary checklist

• I am using the latest stable version of DDEV
• I am using the latest stable version of this add-on

Expected Behavior

ddev adminer should auto login, while plugins should be imported.

Actual Behavior

enabled plugins are not working.

Starting with version 1.0.0 the ddev login changed from Dockerfile to overwriting the index.php. But the docker adminer image implements the plugins in the index.php.

while not using adminerevo anymore, the index.php should not be overwritten.

Steps To Reproduce

No response

Anything else?

No response

[stasadev]

Hi @aneufeld23,

I don't see any errors in our tests (latest run was 3 hours ago).

ddev adminer should auto login, while plugins should be imported.

It should already work.

Are you using the v1.1.3 version of this add-on?

ddev add-on list --installed

Make sure that your Adminer image is the latest one:

docker pull adminer:standalone
ddev restart

And please check that you don't have customized add-on files, without #ddev-generated (the output should not say anything about it):

ddev add-on get ddev/ddev-adminer

And remove .ddev/.env.adminer if you have one, to make sure it works with vanilla setup.

How to add plugins: https://github.com/ddev/ddev-adminer#advanced-customization

[stasadev]

I tested this add-on using a fresh project. Works as expected.

[aneufeld23]

Hi @stasadev , thanks for your quick response.

I tested it on a fresh project, add-on version 1.1.3, latest adminer image, adminer version 5.2.1, ddev 1.24.4 and the tables-filter is not available.
When I added Plugins within the .env.adminer, the plugins are in the correct folder but not recognized from adminer.

The docker image from adminer has it's own index.php
https://github.com/TimWolla/docker-adminer/blob/master/5/index.php, which this plugin is overwriting

configs:
      - source: adminer-index.php
        target: /var/www/html/index.php
        mode: "0444"

plugins are working, when the index.php is not overwritten from the ddev-adminer plugin.

The plugins-enabled folder inside the container is used by the docker image, not by adminer itself. adminer searches for adminer-plugins. plugins in plugins-enabled are imported by the original index.php: https://github.com/TimWolla/docker-adminer/blob/master/5/index.php#L26

[stasadev]

Thanks, so Adminer added it's own index.php in this PR:

• Add Adminer 5.0.1 TimWolla/docker-adminer#187

I'm not yet sure how to rewrite it optimally without overwriting the entire file.

If you have any ideas, PR is welcome, thank you for the report!

[stasadev]

Fixed in:

• fix: correctly load Adminer plugins, fixes #41 #42