Allow use of different core name, fixes #12

[rfay]

• Make Solr core name configurable #12

This makes it easier to use a different core name.

From the updated README:

If you want to use a core name other than the default "dev", edit docker-compose.solr.yaml to

1. Remove the #ddev-generated at the top of the file.
2. Change SOLR_CORE environment variable in the environment: section.
3. Change your Drupal configuration to use the new core.

You can test this PR with https://github.com/rfay/ddev-drupal9-solr/tarball/20221230_config_corename

[claudiu-cristea]

@rfay, I wonder how to test the work in a branch. I've tried:

$ ddev get https://github.com/drud/ddev-drupal9-solr/tree/20221230_config_corename

but it doesn't work

EDIT: Sorry, only now I saw the tarball URL :)

[claudiu-cristea]

Tested and works as expected. Just a nit regarding the Solr name spelling

[claudiu-cristea]

I think we should use the official/capitalized name for Solr s/solr/Solr

[claudiu-cristea]

This is still not capitalized

[rfay]

Thanks, got it.

• You are welcome to do a PR to this to improve the README or anything else, but this PR was about using a different core name.
• When you notice things like this, try to use the "suggest" option when you can, which makes it so the maintainer can just commit your suggestion.

[claudiu-cristea]

@rfay, my remark was only for that occurrence, in the line that was already touched in this PR. I didn't suggest to replace all occurrences. Sorry for any trouble. But true, I'm often forgetting the "suggest" tool.

[rfay]

@claudiu-cristea thanks for reviewing, I need to ask you to do it again. I changed the approach so one can do a ddev get again without editing and removing #ddev-generated, etc.

To review

• Remove .ddev/docker-compose.solr.yaml
• ddev get https://github.com/rfay/ddev-drupal9-solr/tarball/20221230_config_corename
• Add the recommended docker-compose.solr-env.yaml from the README.

[claudiu-cristea]

It works correctly by overriding env vars in docker-compose.solr-env.yaml. I've also run:

docker-compose -f ./.ddev/.ddev-docker-compose-full.yaml config solr

...(BTW, I've missed a ddev docker-compose-config command to wrap docker-compose config) to make sure the env vars are merged correctly and the vars section looks good:

services:
  solr:
    ...
    environment:
      HTTP_EXPOSE: 8983:8983
      SOLR_CORENAME: somecorename
      VIRTUAL_HOST: joinup.ddev.site

This looks good to go. Thank you!

[rfay]

Thanks so much @claudiu-cristea - since you use this your care for it is appreciated. There's still a need for getting @mkalkbrenner's preferred technique into (another) add-on. based on ddev/ddev-contrib#195