Adding JSON export for actor subscription topology#59
Merged
ddrcode merged 2 commits intomaiko-rs:mainfrom Feb 10, 2026
Merged
Conversation
Collaborator
|
Thank you for the contribution, @swaploard. I will review your code later today. |
ddrcode
requested changes
Feb 9, 2026
Collaborator
There was a problem hiding this comment.
Thanks for your first PR and contribution to Maiko!
Please address the issues highlighted in the comments, as the code currently doesn't compile with
cargo build --features serdeEnsure that:
- It compiles
- The
serdefeature dependencies are fixed -
ActorSubscriptionExportstruct is moved insideto_jsonmethod.
Thank yout!
…ing ActorSubscriptionExport
Contributor
Author
|
@ddrcode Thanks for the feedback!
Please let me know if anything else needs adjustment. |
ddrcode
approved these changes
Feb 10, 2026
Collaborator
ddrcode
left a comment
There was a problem hiding this comment.
Thank you for providing the changes, @swaploard - it looks good now. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to export actor hierarchy to JSON for inspection (#58)
This PR adds a Supervisor::to_json() export that provides a machine-readable view of actor subscription topology. This mirrors the information exposed by to_mermaid() but outputs structured JSON suitable for inspection, tooling, or testing.