Skip to content

chore: sync main to dev #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 4, 2024
Merged

chore: sync main to dev #6253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c29085f
feat: add main The Graph subgraphs to use dcl provider (#6213)
juanmahidalgo Jun 12, 2024
85b23a7
Merge pull request #6214 from decentraland/hotfix/hotfix-20240612
Kinerius Jun 12, 2024
f03c228
Merge pull request #6218 from decentraland/release/release-20240618
Ludmilafantaniella Jun 19, 2024
efe43ee
Merge pull request #6224 from decentraland/release/release-20240624
anicalbano Jun 24, 2024
d4a0e99
Merge pull request #6230 from decentraland/release/release20240702
Ludmilafantaniella Jul 2, 2024
bf9648c
Merge pull request #6241 from decentraland/release/release20240726
Ludmilafantaniella Jul 26, 2024
fb95b9b
Merge pull request #6243 from decentraland/release/release20240802
Ludmilafantaniella Aug 2, 2024
bf6738c
Merge pull request #6247 from decentraland/release/release20240826
Ludmilafantaniella Aug 26, 2024
43725c8
Merge pull request #6251 from decentraland/release/release20241002
Ludmilafantaniella Oct 2, 2024
ced5032
fix: comms handshake (#6252)
aleortega Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions browser-interface/packages/shared/comms/adapters/WebSocketAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ export class WebSocketAdapter implements MinimumCommunicationsAdapter {
return this.handleWelcomeMessage(message.welcomeMessage, ws)
}
case 'challengeMessage': {
if (!message.challengeMessage.challengeToSign.match(/^dcl-[^:]*$/)) {
throw new Error('Protocol error: invalid challenge')
}

const authChainJson = JSON.stringify(
Authenticator.signPayload(this.identity, message.challengeMessage.challengeToSign)
)
Expand Down
4 changes: 4 additions & 0 deletions browser-interface/packages/shared/realm/connections/ArchipelagoConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ export async function createArchipelagoConnection(

switch (message.$case) {
case 'challengeResponse': {
if (!message.challengeResponse.challengeToSign.match(/^dcl-[^:]*$/)) {
throw new Error('Protocol error: invalid challenge')
}

const authChainJson = JSON.stringify(
Authenticator.signPayload(identity, message.challengeResponse.challengeToSign)
)
Expand Down
Loading