feat: update how the ownership check is done to the marketplace subgraph #6256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 7SDK 6More |
pravusjif
reviewed
Nov 6, 2024
Member
There was a problem hiding this comment.
Looks OK, @Ludmilafantaniella please run a smoke test on this PR mainly testing if entering with (and without) a registered DCL NAME works as expected.
Also test entering different worlds please.
Ludmilafantaniella
approved these changes
Nov 6, 2024
Contributor
Ludmilafantaniella
left a comment
Ludmilafantaniella
left a comment
There was a problem hiding this comment.
🟢 Smoke test performed on Mac and windows, entering the explorer with and without a registered DCL NAME.
- Teleport through command/GP Carrousel/ map
- Chat and social interactions
- Backpack (equip/unequip wearables and emotes)
- Emoting
- Explorer/worlds/events/Favorites
- Camera Reel
- Map
- Settings
- Scenes visited: Doll House, Seed, Casa Roustan.
- World visited: Metadynelabs, Pravus, Olavra, Fairyland
pravusjif
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
In order to turn this query compatible for both Subsquid and TheGraph/Satsuma (our providers), we need to ask for the owner address that is part of the
ownerentity....
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary