Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Conversation

@boradakash
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation content changes

Other information

Issue Number: #622

@peterpeterparker
Copy link
Contributor

@boradakash thx for the huge PR!!!

Looks good to me. I'll merge it in a branch and will take care of a bit of styling for studio, tests, write the doc, release, integrate in our infrastucture, etc.

But before this, I've got first a small question:

  • what are the options "Leqno" and "Fleqn"?

Moreover can you please:

  • resolve merge conflicts (sorry we did some changes)
  • not use var but instead const or let
  • replace type definition any with effective definitions
  • in the component move extract-math and katex to dependency instead of dev-dependency

But again looks good to me, super 👍

@boradakash
Copy link
Contributor Author

Okay, will do those changes.

Regarding fleqn and leqno:
fleqn: flush left equations
leqno: left equation numbers

You can find more information from here: Katex

@peterpeterparker peterpeterparker changed the base branch from master to math May 10, 2020 07:05
@peterpeterparker peterpeterparker added the enhancement New feature or request label May 10, 2020
@peterpeterparker peterpeterparker merged commit 4ffa306 into deckgo:math May 10, 2020
@peterpeterparker
Copy link
Contributor

Woohoo! Thx for the big PR 👍

@peterpeterparker peterpeterparker linked an issue May 10, 2020 that may be closed by this pull request
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration of MathJax

2 participants