This repository was archived by the owner on Feb 6, 2024. It is now read-only.
feat: rework color, background and style ux #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
peterpeterparker
added
enhancement
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Signed-off-by: peterpeterparker <david.dalbusco@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UX regarding color, background and style is too weird, I have to admit.
Therefore the idea is to split "color" tab in "text and background" and to have the options "color" under "text" or "background"
Moreover, replace the actions in the navigation. For example if slide selected instead of "color" and "background", two button, use "style" as in deck
Likewise, if element is selected, only "style". Furthermore we can more the option "animation" (make sense as "transition" in the deck is in style).
In short: clean the ux for color, background and style. make it comprehensive and follow the same behavior regardless of the selected deck, slide or element