Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Conversation

@peterpeterparker
Copy link
Contributor

@peterpeterparker peterpeterparker commented Sep 3, 2020

Replace the build in publish functions with a cloud functions.

This will allow us to trigger either both or only one option of publish PWA and to GitHub.

@peterpeterparker peterpeterparker added enhancement New feature or request studio "Studio" is the codename for the web editor cloud Studio's cloud functions labels Sep 3, 2020
@peterpeterparker peterpeterparker added this to the v2.3.0 milestone Sep 3, 2020
@peterpeterparker peterpeterparker self-assigned this Sep 3, 2020
@peterpeterparker
Copy link
Contributor Author

@nmattia this PR moves the publish process from the app to the cloud.

this has for advantages:

  • less processing on the client side
  • errors better handled (like if the user close his/her browser, it doesn't end up in a wrong state)

in addition, it will be easy to add a "push to github" button or plug any other deployment, because it introduces kind of a custom made jobs queue for the Firebase cloud.

to unleash it in production and do some "live testing", it is probably better that you sit behind your laptop in case I would break the API or face some error calling the API from Firebase. ping me when you fix my users and let's do that at the same time.

but yeah, kind of a big change in a core process 😅.

@peterpeterparker
Copy link
Contributor Author

I also refactored this morning the collections to get rid of that new collection "deploy", makes things cleaner

giphy

@peterpeterparker peterpeterparker merged commit bf6323d into master Sep 5, 2020
@peterpeterparker peterpeterparker deleted the jobs branch September 5, 2020 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cloud Studio's cloud functions enhancement New feature or request studio "Studio" is the codename for the web editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants