This repository was archived by the owner on Feb 6, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 190
feat: publish with cloud functions #863
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ed8097 to
b197f50
Compare
Contributor
Author
|
@nmattia this PR moves the publish process from the app to the cloud. this has for advantages:
in addition, it will be easy to add a "push to github" button or plug any other deployment, because it introduces kind of a custom made jobs queue for the Firebase cloud. to unleash it in production and do some "live testing", it is probably better that you sit behind your laptop in case I would break the API or face some error calling the API from Firebase. ping me when you fix my users and let's do that at the same time. but yeah, kind of a big change in a core process 😅. |
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cloud
Studio's cloud functions
enhancement
New feature or request
studio
"Studio" is the codename for the web editor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Replace the build in publish functions with a cloud functions.
This will allow us to trigger either both or only one option of publish PWA and to GitHub.