feat(sbom): add experimental GOST SBOM support#48
Merged
Conversation
nervgh
force-pushed
the
feat/sbom/gost-attack-surf-and-gost-sec-func
branch
from
10fc795 to
680fd66
Compare
reyreavman
requested changes
Mar 2, 2026
Collaborator
reyreavman
left a comment
reyreavman
left a comment
There was a problem hiding this comment.
i also think that we need to take into account the GOST fields during the calculation of the checksums
pkg/sbom/gost/injector.go
Outdated
| } | ||
|
|
||
| if !hasAttackSurface && !config.AttackSurface.IsUndefined() { | ||
| if comp.Properties == nil { |
Collaborator
There was a problem hiding this comment.
let's take this outside of the checks and avoid duplication
nervgh
force-pushed
the
feat/sbom/gost-attack-surf-and-gost-sec-func
branch
3 times, most recently
from
c72f193 to
8b3c3d2
Compare
Introducted support for GOST-specific properties in SBOM generation. This allows users to specify `attackSurface` and `securityFunction` attributes at both the global build and per-image configuration levels. Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
Move GOST component validation and fragment preparation to a dedicated method to ensure they happen before checksum calculation. Extract stable checksum logic into a helper method and add unit tests to verify consistency across different merge options. Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
properties instead of just injecting them. Added a temporary checksum stub in the BOM checksum calculation to be replaced with a stable implementation later, and updated E2E test expectations accordingly. Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
nervgh
force-pushed
the
feat/sbom/gost-attack-surf-and-gost-sec-func
branch
from
25753da to
4628240
Compare
reyreavman
requested changes
Mar 3, 2026
| return o.BaseBOM == nil && len(o.ImportBOMs) == 0 && o.FragmentBOM == nil | ||
| } | ||
|
|
||
| func (o MergeOpts) Checksum() string { |
Collaborator
There was a problem hiding this comment.
it seems to me that the GOST fields are still not taken into account in the calculation of the checksum and these tests confirm it
Signed-off-by: Alexandr Zaytsev <alexandr.zaytsev@flant.com>
reyreavman
approved these changes
Mar 4, 2026
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducted support for GOST-specific properties in SBOM generation. This allows users to specify
attackSurfaceandsecurityFunctionattributes at both the global build and per-image configuration levels.