feat: check werf images for using base images and ovveride user #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the
werflinter by enhancing validation logic, refactoring existing methods, and adding comprehensive unit tests. Additionally, it modifies theWriteProtomethod inpromremote.goto improve context handling. The most important changes are grouped below by theme:Enhancements to
werflinter:FromImageandImageSpec.Config.User) to thewerfFilestruct for more granular validation ofwerf.yamlfiles.LintWerfFileto support module-specific validation, handle invalid YAML documents gracefully, and validate new fields such asfromImageandimageSpec.config.user.splitManifestsfunction to correctly split YAML documents and return a slice instead of a map.isWerfImagesCorrectto validate image paths against stricter criteria (baseorcommon).Unit tests for
werflinter:LintWerfFile, including validation offromImage, handling of deprecated directives, and multiple YAML documents.Example:
Added some excludes:
imageSpec.config.user:checks. This checks produced warn. After fixing, these exceptions need to be removed.