Skip to content

Conversation

@nevermarine
Copy link
Collaborator

@nevermarine nevermarine commented Sep 29, 2025

Description

Return docs linting.

Why do we need it, and what problem does it solve?

Revert #1494

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

Summary by Sourcery

CI:

  • Remove global documentation impact setting to restore docs lint rules

Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
@nevermarine nevermarine added this to the v1.2.0 milestone Sep 29, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Re-enables documentation linting in the CI configuration by reverting the override in .dmtlint.yaml that disabled it.

Flow diagram for documentation linting in CI

flowchart TD
    Start["Start CI Pipeline"] --> DmtLint["Run Documentation Linter (dmtlint)"]
    DmtLint -->|Lint Passed| NextStep["Continue Pipeline"]
    DmtLint -->|Lint Failed| Warn["Warn or Fail Pipeline"]
Loading

File-Level Changes

Change Details Files
Restore documentation linting in dmtlint config
  • Removed the global linters-settings override that disabled documentation linting
.dmtlint.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nevermarine nevermarine marked this pull request as ready for review September 29, 2025 14:13
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
@nevermarine nevermarine merged commit c56bdbc into main Sep 29, 2025
27 of 28 checks passed
@nevermarine nevermarine deleted the chore/ci/return-docs-lint branch September 29, 2025 14:34
Isteb4k pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
(cherry picked from commit c56bdbc)
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
nevermarine added a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
(cherry picked from commit c56bdbc)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
(cherry picked from commit c56bdbc)
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
nevermarine added a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
(cherry picked from commit c56bdbc)
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants