-
Notifications
You must be signed in to change notification settings - Fork 2
chore(ci): backport update 3p versions for cve fixes (#1572) #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com> Signed-off-by: Isteb4k <dmitry.rakitin@flant.com> Signed-off-by: Nikita Korolev <nikita.korolev@flant.com> Co-authored-by: Dmitry Rakitin <dmitry.rakitin@flant.com> Co-authored-by: Nikita Korolev <141920865+universal-itengineer@users.noreply.github.com> Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates third-party component versions to address CVEs and streamlines CI build scripts by consolidating git clone logic and removing manual module upgrades. Flow diagram for streamlined git clone logic in CI build scriptsflowchart TD
A["Start build script"] --> B["Read SOURCE_REPO secret"]
B --> C["Construct git repo URL and branch/tag"]
C --> D["git clone --depth=1 <repo_url> --branch <tag> /src/<repo>"]
D --> E["Remove .git directory"]
E --> F["Continue build steps"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- In images/virt-artifact/werf.inc.yaml you clone into /src/kubevirt but then cd into /kubevirt—please update the working directory path to match the clone target.
- Consider extracting the common repo URL and clone logic into a shared variable or helper to reduce duplication across your werf.inc.yaml scripts.
- After bumping module versions in virtualization-artifact, don’t forget to regenerate go.sum (e.g. via go mod tidy) so that the checksum file stays in sync with your updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In images/virt-artifact/werf.inc.yaml you clone into /src/kubevirt but then cd into /kubevirt—please update the working directory path to match the clone target.
- Consider extracting the common repo URL and clone logic into a shared variable or helper to reduce duplication across your werf.inc.yaml scripts.
- After bumping module versions in virtualization-artifact, don’t forget to regenerate go.sum (e.g. via go mod tidy) so that the checksum file stays in sync with your updates.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
universal-itengineer
approved these changes
Oct 14, 2025
4 tasks
nevermarine
added a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com> Signed-off-by: Isteb4k <dmitry.rakitin@flant.com> Signed-off-by: Nikita Korolev <nikita.korolev@flant.com> Co-authored-by: Dmitry Rakitin <dmitry.rakitin@flant.com> Co-authored-by: Nikita Korolev <141920865+universal-itengineer@users.noreply.github.com> Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Isteb4k
added a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com> Signed-off-by: Isteb4k <dmitry.rakitin@flant.com> Signed-off-by: Nikita Korolev <nikita.korolev@flant.com> Co-authored-by: Dmitry Rakitin <dmitry.rakitin@flant.com> Co-authored-by: Nikita Korolev <141920865+universal-itengineer@users.noreply.github.com> Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
nevermarine
added a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com> Signed-off-by: Isteb4k <dmitry.rakitin@flant.com> Signed-off-by: Nikita Korolev <nikita.korolev@flant.com> Co-authored-by: Dmitry Rakitin <dmitry.rakitin@flant.com> Co-authored-by: Nikita Korolev <141920865+universal-itengineer@users.noreply.github.com> Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update 3p versions for cve fixes (#1572)
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries