main: Increase runtime GC memlimit params. #3485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current soft upper memory limit was calculated based on the main network and prior to the addition of the mixing pool. As can be expected, the mixing pool requires extra memory which implies the soft memory limit should be raised to account for it. This hasn't been an issue on the main network because the limit was intentionally set to include an additional overhead buffer to help future proof it which has been large enough to handle the additional memory requirements. However, the test network also requires additional memory due to having a significantly longer chain. The combination of those two factors comes very close to exhausting that additional overhead buffer and therefore can lead to excessive CPU utilization on the test network as the GC no longer has much working room to efficiently perform its job. In order to address the aforementioned, this bumps the soft upper memory limit from 1.5 GiB to 1.8 GiB which accounts for both sources of increased memory usage along with a good overhead buffer on par with the original value prior to the additional memory requirements. Note that the overall minimum recommended memory in the README does not need to be increased since the new limit is still 10% under the recommendation.
davecgh
force-pushed
the
main_bump_runtime_memlimit
branch
from
ee80766 to
62a4051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current soft upper memory limit was calculated based on the main network and prior to the addition of the mixing pool.
As can be expected, the mixing pool requires extra memory which implies the soft memory limit should be raised to account for it.
This hasn't been an issue on the main network because the limit was intentionally set to include an additional overhead buffer to help future proof it which has been large enough to handle the additional memory requirements.
However, the test network also requires additional memory due to having a significantly longer chain. The combination of those two factors comes very close to exhausting that additional overhead buffer and therefore can lead to excessive CPU utilization on the test network as the GC no longer has much working room to efficiently perform its job.
In order to address the aforementioned, this bumps the soft upper memory limit from 1.5 GiB to 1.8 GiB which accounts for both sources of increased memory usage along with a good overhead buffer on par with the original value prior to the additional memory requirements.
Note that the overall minimum recommended memory in the README does not need to be increased since the new limit is still 10% under the recommendation.