Skip to content

Conversation

mirceapasoi
Copy link
Contributor

Proposed changes

_emit is not being awaited, which leads to RuntimeWarning: coroutine 'AsyncLiveClient._emit' was never awaited self._emit(LiveTranscriptionEvents.Error, error)

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@davidvonthenen
Copy link
Contributor

oooof! nice catch @mirceapasoi Thanks for the contribution!

@davidvonthenen davidvonthenen merged commit 9784ce0 into deepgram:main Feb 14, 2024
@davidvonthenen davidvonthenen added the bug Something isn't working label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants