Skip to content

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Feb 23, 2024

Proposed changes

Addresses issue: #272

Changes:

  • This implements KeepAlives and Protocol pings for AsyncClient
  • Standardizes the ping loop thread between the two clients (allows the thread to exit earlier instead of waiting for longer periods of time)

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@davidvonthenen davidvonthenen merged commit e832849 into deepgram:main Feb 23, 2024
@davidvonthenen davidvonthenen deleted the implement-keepalive-async branch February 23, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants