Skip to content

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Nov 24, 2025

  • For general widgets to size correctly, related to DH-20953 for AG Grid

- For general widgets to size correctly, related to DH-20953 for AG Grid
@mofojed mofojed requested a review from dsmmcken November 24, 2025 14:12
@mofojed mofojed self-assigned this Nov 24, 2025
mofojed added a commit to mofojed/deephaven-plugins that referenced this pull request Nov 24, 2025
- Adding a generic widget-container class that can be used by any widget
- See deephaven/web-client-ui#2581 for the web-client-ui updates
- Not removing the old class so it doesn't break in the interim
- Set up deephaven.ui to handle .widget-container correctly
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.49%. Comparing base (79a44fa) to head (f1f201b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2581   +/-   ##
=======================================
  Coverage   45.49%   45.49%           
=======================================
  Files         771      771           
  Lines       43580    43580           
  Branches    11026    11026           
=======================================
  Hits        19825    19825           
  Misses      23739    23739           
  Partials       16       16           
Flag Coverage Δ
unit 45.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mofojed added a commit to deephaven/deephaven-plugins that referenced this pull request Nov 24, 2025
#1271)

- Adding a generic widget-container class that can be used by any widget
- See deephaven/web-client-ui#2581 for the
web-client-ui updates
- Not removing the old class so it doesn't break in the interim
- Set up deephaven.ui to handle `.widget-container` correctly
@mofojed mofojed merged commit 89dc832 into deephaven:main Nov 24, 2025
11 checks passed
@mofojed mofojed deleted the widget-container-scss branch November 24, 2025 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants