return 404 when no matching route is found#1067
Merged
2 commits merged intooapi-codegen:masterfrom Jul 28, 2023
sonu27:master
Merged
return 404 when no matching route is found#10672 commits merged intooapi-codegen:masterfrom sonu27:master
2 commits merged intooapi-codegen:masterfrom
sonu27:master
Conversation
|
Should be 405. 404 is resource not found contrary to method not allowed/ not registered. |
Contributor
Author
|
Currently, it's returning 400 which is not correct. |
sonu27
changed the title
|
fair point |
Contributor
Author
|
Just updated other middlewares too |
Contributor
Author
|
@deepmap-marcinr What do you think? |
ghost
merged commit
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
* return 404 when a matching route is not found * update other middleware and tests
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
* return 404 when a matching route is not found * update other middleware and tests
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1066