fix(validation): skip email validation when the types.Email is nullab…#1107
Merged
1 commit merged intooapi-codegen:masterfrom Jul 28, 2023
Merged
Conversation
…le and the email isn't provided
kayn1
approved these changes
Jun 13, 2023
|
👌 👍 |
ghost
merged commit
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
…le and the email isn't provided (oapi-codegen#1107) Co-authored-by: Henri Parquet <henri.parquet@banked.com>
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
…le and the email isn't provided (oapi-codegen#1107) Co-authored-by: Henri Parquet <henri.parquet@banked.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT:
*types.Emailwith a nil valueWHY:
Currently validation is performed when unmarshaling empty emails even when it shouldn't (using a pointer type is akin to a nullable JSON field and therefore shouldn't be validated). This results in being unable to retrieve data using the generated client if the target API returns a null email in the payload even when this one isn't required.
HOW:
*types.Emailwith a nil value