fix(stricttpl): move custom header interpolation after set content-type#1133
Merged
1 commit merged intooapi-codegen:masterfrom Jul 28, 2023
Merged
Conversation
b5e2806 to
db5e8b9
Compare
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
…pe (oapi-codegen#1133) Co-authored-by: Henri Parquet <henri.parquet@banked.com>
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
…pe (oapi-codegen#1133) Co-authored-by: Henri Parquet <henri.parquet@banked.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Move the custom response header interpolation in the strict interface template after the
Content-Typeheader is set in order to allow overriding it if neededWHY
Currently one cannot define a custom
Content-Typeheader if he wished.For example if one wants to set a
Content-Typeofapplication/json; charset-utf8for backwards compatibility support the only currently available option in openapi v3 would be to add a custom header ofContent-Typewith a default value like the following :However in in strict interface implementation custom headers are interpolated prior to the
Content-Typebeing set and therefore setting a customContent-Typebecomes impossible.HOW
By moving the custom headers interpolation after the call to set the
Content-Typewe allow greater flexibility.