fix: strict server with union type#939
Merged
1 commit merged intooapi-codegen:masterfrom Jun 6, 2023
Merged
Conversation
kbakdev
approved these changes
Jan 25, 2023
Contributor
Author
|
@deepmap-marcinr sorry for the direct ping, but I wonder if this solution looks reasonable. |
Contributor
|
I think the proper solution would be to force body to be a separate type with MarshalJSON method (as with other inline unions). For now it looks like a hacky workaround. |
johanneswuerbach
force-pushed
the
fix-union
branch
3 times, most recently
from
e4deba3 to
ad98f59
Compare
johanneswuerbach
force-pushed
the
fix-union
branch
from
ad98f59 to
e87bc98
Compare
Contributor
Author
|
@deepmap-marcinr could this also be accepted as a workaround for now? |
|
Yeah, this looks ok. I'll merge it. Thank you. I have been thinking quite a lot on improving the anyOf/oneOf handling and it's hard - the strict server code was added after the more generic code and there are many edge cases such as this. |
ghost
merged commit
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #748
Inspired by #865
Encode the
.unionproperty when dealing with a.uniontype.