Skip to content

Fix : segmentation fault when deepks_scf=0 but deepks_out_labels=1 #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix : segmentation fault when deepks_scf=0 but deepks_out_labels=1 #5090

merged 2 commits into from
Sep 13, 2024

Conversation

@xuan112358
Copy link
Collaborator

Linked Issue

Fix #5052
In case of no deepks_scf but out_deepks_label, size of DMR would mismatch with deepks-orbitals

@xuan112358 xuan112358 requested a review from dyzheng September 12, 2024 13:19
@mohanchen mohanchen merged commit 548ac3c into deepmodeling:develop Sep 13, 2024
@mohanchen mohanchen added the Bugs Bugs that only solvable with sufficient knowledge of DFT label Sep 13, 2024
@xuan112358 xuan112358 deleted the fix_deepks_out_labels branch September 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohanchen mohanchen mohanchen approved these changes

@dyzheng dyzheng Awaiting requested review from dyzheng

Assignees

No one assigned

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segmentation fault when deepks_out_labels 1

2 participants

@xuan112358 @mohanchen