Refactor ModuleIO::read/write_cube()
#5109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyzheng
approved these changes
Sep 17, 2024
kirk0830
reviewed
Sep 20, 2024
| namespace ModuleIO | ||
| { | ||
| bool read_cube( | ||
| extern bool read_cube( |
Collaborator
There was a problem hiding this comment.
could you explain why you add extern here?
Collaborator
Author
There was a problem hiding this comment.
Writing extern explicitly will ask the compiler to report an error if the functions in .h and .cpp are different.
PeizeLin
changed the title
ModuleIO::read/write_cube()
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some codes in
ModuleIO::read_cube()andModuleIO::write_cube()to new functionsModuleIO::read_cube_core_match(),ModuleIO::read_cube_core_mismatch()andModuleIO::write_cube_core().Refactor these functions.
For users, there is no change in input or output.