Fix: fix cusolvermp compiling error with icpc and update ks_solver doc #5196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no autotest workflow finds this bug, this is a big problem and present case should not happen, I think we need some tests that can ensure functionalities work as expected. Plus, is there any intergrated test for LCAO GPU? if not, could you add some? |
|
Adding the relevant tests is a bit complicated and will take some time. I suggest we merge this PR for now, and I will add the necessary tests in a subsequent PR. |
mohanchen
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
ENABLE_CUSOLVERMP=ON.