Feature: add interface Gint::psir_func
#5380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeizeLin
changed the title
Gint::psir_func
dzzz2001
approved these changes
Nov 2, 2024
|
Hi @PeizeLin , could you briefly share your plans for any future changes to the grid integration module? I'm planning to do a major refactoring of this module soon and would like to make sure your requirements are included in the process. |
mohanchen
approved these changes
Nov 7, 2024
Fisherd99
pushed a commit
to Fisherd99/abacus-BSE
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two function objects
psir_funcinGint, changing the NAOpsir_ylmtopsir_ylm_new = psir_func (psir_ylm)when calculategint_rho()andgint_vl().It's an interface for the future development. To the existing codes, it's just
psir_ylm_new = psi_ylmas default .