Skip to content

Conversation

@pxlxingliang
Copy link
Collaborator

@pxlxingliang pxlxingliang commented Nov 28, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4335

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@pxlxingliang
Copy link
Collaborator Author

pxlxingliang commented Nov 28, 2024

312_NO_GO_wfc_get_wf is failed, and I will comment out it in this PR, and it should be opened after it is fixed.

Related issue: #5635

@caic99
Copy link
Member

caic99 commented Nov 28, 2024

@pxlxingliang As you can see, there are indeed cases with correct results and abnormal exit codes 🤣

@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Nov 28, 2024
@mohanchen mohanchen merged commit d236215 into deepmodeling:develop Nov 28, 2024
14 checks passed
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
* Test: check if abacus end normally in CI test

* comment out 312_NO_GO_wfc_get_wf

---------

Co-authored-by: root <pxlxingliang>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test: our CICD auto test workflow does not work fully as expected

3 participants