Skip to content

Conversation

@pxlxingliang
Copy link
Collaborator

…g of function "inline void operator=(std::complex c)"

range: source/module_base

…g of function "inline void operator=(std::complex <double> c)"

range: source/module_base
@caic99
Copy link
Member

caic99 commented Jan 11, 2022

Please split your test and bug-fixing into two separated PRs.

@caic99 caic99 linked an issue Jan 11, 2022 that may be closed by this pull request
…compexarray_test.cpp

reange: module_base/complexarray.[h,cpp], module_base/test/
TEST_F(ComplexArray_test,operator_equal)
{
c2 = a2; //c2 is not assigned
b2 = a2; //b2 is arrigned by a complex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here?

range: module_base/test/complexarray_test.cpp
@caic99 caic99 self-requested a review January 13, 2022 04:33
@caic99 caic99 merged commit b2ebdc8 into deepmodeling:develop Jan 13, 2022
@pxlxingliang pxlxingliang deleted the performance branch January 13, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect using of "inline" function in module_base/complexarray.h

2 participants