Skip to content

fix a bug in ReactingParcel #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2022
Merged

fix a bug in ReactingParcel #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ void Foam::ReactingParcel<ParcelType>::calcPhaseChange
// Average molecular weight of carrier mix - assumes perfect gas
const scalar Wc = td.rhoc()*RR*td.Tc()/td.pc();

composition.carrier().calcCp(Tsdash, td.pc());
forAll(dMassPC, i)
{
const label cid = composition.localToCarrierId(idPhase, i);
Expand Down Expand Up @@ -260,6 +261,7 @@ void Foam::ReactingParcel<ParcelType>::cellValueSourceCorrection
td.Uc() = (td.Uc()*massCell + cloud.UTrans()[this->cell()])/massCellNew;

scalar CpEff = 0.0;
cloud.composition().carrier().calcCp(td.Tc(), td.pc());
forAll(cloud.rhoTrans(), i)
{
scalar Y = cloud.rhoTrans(i)[this->cell()]/addedMass;
Expand Down Expand Up @@ -348,15 +350,15 @@ void Foam::ReactingParcel<ParcelType>::correctSurfaceValues
scalar sumYiSqrtW = 0;
scalar sumYiCbrtW = 0;

thermo.carrier().calcMu(T, td.pc());
thermo.carrier().calcCp(T, td.pc());
forAll(Ys, i)
{
const scalar W = thermo.carrier().Wi(i);
const scalar sqrtW = sqrt(W);
const scalar cbrtW = cbrt(W);

rhos += Xs[i]*W;
thermo.carrier().calcMu(T, td.pc());
thermo.carrier().calcCp(T, td.pc());
mus += Ys[i]*sqrtW*thermo.carrier().mu(i, td.pc(), T);
kappas += Ys[i]*cbrtW*thermo.carrier().kappa(i, td.pc(), T);
Cps += Xs[i]*thermo.carrier().Cp(i, td.pc(), T);
Expand Down Expand Up @@ -502,6 +504,7 @@ void Foam::ReactingParcel<ParcelType>::calc
scalar dm = np0*mass0;

// Absorb parcel into carrier phase
composition.carrier().calcH(T0, td.pc());
forAll(Y_, i)
{
scalar dmi = dm*Y_[i];
Expand Down Expand Up @@ -563,6 +566,7 @@ void Foam::ReactingParcel<ParcelType>::calc
if (cloud.solution().coupled())
{
// Transfer mass lost to carrier mass, momentum and enthalpy sources
composition.carrier().calcH(T0, td.pc());
forAll(dMass, i)
{
scalar dm = np0*dMass[i];
Expand Down