chore(dependencies): Downgrade matplotlib-inline for Python 3.10 #26

m1so · 2025-11-10T14:23:17Z

Summary by CodeRabbit

Chores
- Added conditional packaging constraints for matplotlib-inline across Python versions.
- Removed a duplicate dependency entry for a cleaner configuration.
- Updated CI license-check to ignore matplotlib-inline.
- No changes to exported/public APIs or public declarations.

linear · 2025-11-10T14:23:20Z

BLU-5141 Matplotlib broken in Python 3.10

coderabbitai · 2025-11-10T14:23:28Z

📝 Walkthrough

Walkthrough

pyproject.toml: removed a duplicate toml>=0.10.0,<1.0.0 entry and added conditional matplotlib-inline dependencies split by Python version (>=0.1.7,<0.2.0 for Python <=3.10; >=0.2.1,<0.3.0 for Python >=3.11).
.github/workflows/ci.yml: added matplotlib-inline to the pip-licenses ignore list; CI includes conditional steps that may pin importlib-metadata for specific Python matrix entries.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Dev as Contributor
participant Repo as Repository (pyproject.toml, CI)
participant CI as GitHub Actions
participant Env as Runner (matrix job)

Dev->>Repo: open PR with dependency + CI changes
Repo->>CI: push triggers workflow
CI->>Env: spawn job(s) for each Python version
note left of Env #E6F0FF: Dependency resolution phase
Env->>Env: read pyproject.toml
alt Python <= 3.10
Env->>Env: select matplotlib-inline >=0.1.7,<0.2.0
else Python == 3.11+
Env->>Env: select matplotlib-inline >=0.2.1,<0.3.0
end
note right of Env #FFF4E6: CI license step
Env->>Env: run pip-licenses (matplotlib-inline ignored)
opt Python matrix has special case
Env->>Env: run conditional pin for importlib-metadata (if configured)
end
Env->>CI: report job results (checks/tests)

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title accurately captures the main change: adding conditional matplotlib-inline dependencies with version downgrades for Python 3.10.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 66b5355 and 4e5b51a.

⛔ Files ignored due to path filters (1)

poetry.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

.github/workflows/ci.yml (1 hunks)
pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Test - Python 3.11
GitHub Check: Test - Python 3.9
GitHub Check: Test - Python 3.12
GitHub Check: Test - Python 3.13
GitHub Check: Test - Python 3.10
GitHub Check: Typecheck - 3.13
GitHub Check: Build and push artifacts for Python 3.11
GitHub Check: Build and push artifacts for Python 3.12
GitHub Check: Build and push artifacts for Python 3.9
GitHub Check: Build and push artifacts for Python 3.13
GitHub Check: Build and push artifacts for Python 3.10

🔇 Additional comments (2)

.github/workflows/ci.yml (1)

142-142: License check ignore list updated appropriately.

Adding matplotlib-inline to the ignore list is sensible given that pip-licenses often cannot detect its license. This prevents CI failures while the dependency is now explicitly pinned.

pyproject.toml (1)

127-128: Dependencies correctly pinned with version markers and upper bounds.

matplotlib-inline 0.2.1 (released Oct 23, 2025) supports Python 3.11, confirming the newer version works for Python 3.11+. The conditional logic properly routes Python 3.9–3.10 to 0.1.7–0.1.x and Python 3.11–3.13 to 0.2.1–0.2.x. The comment clarifying the matplotlib 3.6.3 incompatibility rationale for the older version is noted; verify locally that 0.1.7 works as expected with your environment's matplotlib version on Python ≤3.10.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-11-10T14:25:23Z

📦 Python package built successfully!

Version: 1.1.3.dev11+6b2756e
Wheel: deepnote_toolkit-1.1.3.dev11+6b2756e-py3-none-any.whl

Install:

pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.3.dev11%2B6b2756e/deepnote_toolkit-1.1.3.dev11%2B6b2756e-py3-none-any.whl"

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cc6a555 and 9c6b88c.

⛔ Files ignored due to path filters (1)

poetry.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

pyproject.toml

codecov · 2025-11-10T14:27:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.40%. Comparing base (7d91cd6) to head (5241065).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   76.94%   75.40%   -1.55%     
==========================================
  Files          99       99              
  Lines        5514     5627     +113     
  Branches      754      785      +31     
==========================================
  Hits         4243     4243              
- Misses       1271     1384     +113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deepnote-bot · 2025-11-10T14:33:14Z

🚀 Review App Deployment Started

📝 Description	🌐 Link / Info
🌍 Review application	ra-26
🔑 Sign-in URL	Click to sign-in
📊 Application logs	View logs
🔄 Actions	Click to redeploy
🚀 ArgoCD deployment	View deployment
⏰ Last deployed	2025-11-11 17:17:15 (UTC)
📜 Deployed commit	`a72bad371cbf3a241ca342c7e8a63c611b9fea8e`
🛠️ Toolkit version	`6b2756e`

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0621ece and 1539037.

⛔ Files ignored due to path filters (1)

poetry.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Test - Python 3.13
GitHub Check: Test - Python 3.12
GitHub Check: Test - Python 3.10
GitHub Check: Test - Python 3.11
GitHub Check: Typecheck - 3.13
GitHub Check: Typecheck - 3.10
GitHub Check: Build and push artifacts for Python 3.11
GitHub Check: Build and push artifacts for Python 3.12
GitHub Check: Build and push artifacts for Python 3.13
GitHub Check: Build and push artifacts for Python 3.10
GitHub Check: Build and push artifacts for Python 3.9

pyproject.toml

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 253ddf9 and 59388e5.

📒 Files selected for processing (2)

.github/workflows/ci.yml (2 hunks)
pyproject.toml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: Build and push artifacts for Python 3.9
GitHub Check: Build and push artifacts for Python 3.11
GitHub Check: Build and push artifacts for Python 3.13
GitHub Check: Build and push artifacts for Python 3.12
GitHub Check: Build and push artifacts for Python 3.10
GitHub Check: Test - Python 3.11
GitHub Check: Test - Python 3.13
GitHub Check: Test - Python 3.12
GitHub Check: Test - Python 3.10

🔇 Additional comments (2)

pyproject.toml (1)

215-215: Poetry version constraint update aligns with CI change.

Line 215 properly downgrades requires-poetry from >=2.2 to >=2.1, matching .github/workflows/ci.yml line 17 (POETRY_VERSION: "2.1.4").

.github/workflows/ci.yml (1)

17-17: Original review comment is incorrect.

matplotlib-inline is a transitive dependency (visible in poetry.lock at multiple locations), not a direct dependency. It's correctly commented out in pyproject.toml because it's not directly required, yet properly appears in the CI ignore list to handle license checks for transitive dependencies pulled in by other packages. No code changes needed.

Likely an incorrect or invalid review comment.

pyproject.toml

…-in-python-310

chore(dependencies): Downgrade matplotlib-inline for Python 3.10

9c6b88c

coderabbitai bot requested changes Nov 10, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

m1so added 4 commits November 10, 2025 15:39

fix: Ignore matplotlib-inline unknown license

b261633

chore: Bump Poetry to v2.2.1 (from v2.2.0)

0621ece

test: Downgrade matplotlib-inline to 0.1 for all Python versions

1539037

test: Remove matplotlib-inline to see if CI works correctly

253ddf9

coderabbitai bot requested changes Nov 10, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

test: Downgrade to Poetry 2.1.4

59388e5

coderabbitai bot requested changes Nov 10, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

m1so added 3 commits November 10, 2025 17:31

test: Pin importlib-metadata for Python 3.9

66b5355

fix: Revert failed importlib-metadata downgrade

36af290

fix: Revert changes after Poetry installation step now succeeds

4e5b51a

coderabbitai bot approved these changes Nov 11, 2025

View reviewed changes

Merge branch 'main' into michalbaumgartner/blu-5141-matplotlib-broken…

5241065

…-in-python-310

m1so marked this pull request as ready for review November 11, 2025 17:09

m1so requested a review from a team as a code owner November 11, 2025 17:09

FilipPyrek approved these changes Nov 11, 2025

View reviewed changes

m1so merged commit 7c193ca into main Nov 11, 2025
33 of 34 checks passed

m1so deleted the michalbaumgartner/blu-5141-matplotlib-broken-in-python-310 branch November 11, 2025 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(dependencies): Downgrade matplotlib-inline for Python 3.10 #26

chore(dependencies): Downgrade matplotlib-inline for Python 3.10 #26

Uh oh!

m1so commented Nov 10, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Nov 10, 2025

Uh oh!

coderabbitai bot commented Nov 10, 2025 •

edited

Loading

Walkthrough

Sequence Diagram(s)

Uh oh!

github-actions bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

deepnote-bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore(dependencies): Downgrade matplotlib-inline for Python 3.10 #26

chore(dependencies): Downgrade matplotlib-inline for Python 3.10 #26

Uh oh!

Conversation

m1so commented Nov 10, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Nov 10, 2025

Uh oh!

coderabbitai bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Pre-merge checks

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

deepnote-bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

m1so commented Nov 10, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 10, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading

codecov bot commented Nov 10, 2025 •

edited

Loading

deepnote-bot commented Nov 10, 2025 •

edited

Loading