Skip to content

Conversation

@m1so
Copy link
Member

@m1so m1so commented Oct 30, 2025

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows infrastructure across CI/CD and deployment pipelines.

@m1so m1so requested review from jamesbhobbs and mfranczel October 30, 2025 18:32
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

📝 Walkthrough

Walkthrough

GitHub Actions workflow files are updated to use ubuntu-latest as the runner instead of ubicloud-standard-2. This affects all jobs across three workflows: .github/workflows/cd.yml, .github/workflows/ci.yml, and .github/workflows/clean-up-review-app-deployment.yml. No changes to job logic, steps, or conditional execution occur.

Possibly related PRs

  • deepnote/deepnote-toolkit#248: Modifies runner labels in the same workflow files, specifically switching CI jobs (inverse direction of this change).
  • deepnote/deepnote-toolkit#201: Updates GitHub Actions runner configuration across the same workflow files.
  • deepnote/deepnote-toolkit#158: Updates runner labels in workflows that were added during CircleCI migration.

Suggested reviewers

  • jamesbhobbs
  • mfranczel

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: Use GitHub actions runners instead of Ubicloud" accurately reflects the main change across all three modified workflow files, which uniformly replace ubicloud-standard-2 runners with ubuntu-latest. The title is concise, specific, and avoids vague terminology, clearly communicating the primary change to readers scanning the commit history.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8b2941b and 59da459.

📒 Files selected for processing (3)
  • .github/workflows/cd.yml (9 hunks)
  • .github/workflows/ci.yml (10 hunks)
  • .github/workflows/clean-up-review-app-deployment.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Build and push artifacts for Python 3.9
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Test - Python 3.10
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Test - Python 3.12
  • GitHub Check: Test - Python 3.9
🔇 Additional comments (3)
.github/workflows/clean-up-review-app-deployment.yml (1)

10-10: Looks good. Clean migration; gh CLI and jq are available on ubuntu-latest. The bash logic has no OS-specific dependencies.

.github/workflows/ci.yml (1)

25-25: All 10 jobs updated consistently. Tools are standard (Python, Poetry, Docker, Java, security scanners)—all available on ubuntu-latest. The semgrep job uses an explicit container image, so runner distro doesn't affect it.

Also applies to: 63-63, 105-105, 161-161, 219-219, 235-235, 260-260, 280-280, 396-396, 437-437

.github/workflows/cd.yml (1)

32-32: All 9 jobs migrated cleanly. Docker builds, AWS credential exchange (OIDC), and custom actions are all runner-agnostic. No platform-specific config detected.

Also applies to: 123-123, 146-146, 285-285, 309-309, 354-354, 412-412, 453-453, 494-494


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

📦 Python package built successfully!

  • Version: 1.0.0.dev5+bc9565f
  • Wheel: deepnote_toolkit-1.0.0.dev5+bc9565f-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.0.0.dev5%2Bbc9565f/deepnote_toolkit-1.0.0.dev5%2Bbc9565f-py3-none-any.whl"

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (5ca512a) to head (4e9c5c7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files          99       99           
  Lines        5476     5476           
  Branches      748      748           
=======================================
  Hits         4195     4195           
  Misses       1281     1281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1so m1so requested a review from a team as a code owner October 30, 2025 18:38
@m1so m1so enabled auto-merge (squash) October 30, 2025 18:38
@deepnote-bot
Copy link

deepnote-bot commented Oct 30, 2025

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-5
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-10-30 18:44:32 (UTC)
📜 Deployed commit 193337cfd90f2c507d870a06b2be90fc18ed066b
🛠️ Toolkit version bc9565f

@m1so m1so merged commit 1b4d41d into main Oct 30, 2025
31 checks passed
@m1so m1so deleted the mb/switch-from-ubicloud-to-gha-runners branch October 30, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants