Fix GPU images to work with toolkit #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc2p
force-pushed
the
hannes/pla-3506-fix-gpu-images-to-work-with-toolkit
branch
from
18d5960 to
d227869
Compare
mfranczel
approved these changes
Jan 22, 2025
chudyandrej
reviewed
Jan 22, 2025
|
|
||
| - build-and-push-gpu: | ||
| name: Tensorflow 2.9 | ||
| cuda-tag: "11.4.3-runtime-ubuntu20.04" |
Contributor
There was a problem hiding this comment.
lets split cuda update to separate PR please. Eventually we need to create new tags like cudax.x-tf-x.x
Contributor
|
@hc2p this can silently update CUDA for all GPU users. That can be incompatible with the GPU hardware that we are currently offering. Lets split this CUDA update to seprate PR where we introduce new tags including cuda version |
hc2p
force-pushed
the
hannes/pla-3506-fix-gpu-images-to-work-with-toolkit
branch
from
d227869 to
dfb42b8
Compare
Contributor
Author
|
@chudyandrej But i'm happy to split this off into a separate PR. |
Contributor
Author
chudyandrej
approved these changes
Jan 22, 2025
hc2p
added a commit
that referenced
this pull request
Feb 4, 2025
…o-work-with-toolkit Fix GPU images to work with toolkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.