Skip to content

fix: Dataframe SQL block support #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix: Dataframe SQL block support #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,22 @@ export class SqlIntegrationEnvironmentVariablesProvider implements ISqlIntegrati
}

try {
// Handle internal DuckDB integration specially
if (integrationId === DATAFRAME_SQL_INTEGRATION_ID) {
const envVarName = convertToEnvironmentVariableName(getSqlEnvVarName(integrationId));
const credentialsJson = JSON.stringify({
url: 'deepnote+duckdb:///:memory:',
params: {},
param_style: 'qmark'
});

envVars[envVarName] = credentialsJson;
logger.debug(
`SqlIntegrationEnvironmentVariablesProvider: Added env var for dataframe SQL integration`
);
continue;
}

const config = await this.integrationStorage.getIntegrationConfig(integrationId);
if (!config) {
logger.warn(
Expand All @@ -162,7 +178,7 @@ export class SqlIntegrationEnvironmentVariablesProvider implements ISqlIntegrati
const credentialsJson = convertIntegrationConfigToJson(config);

envVars[envVarName] = credentialsJson;
logger.info(
logger.debug(
`SqlIntegrationEnvironmentVariablesProvider: Added env var ${envVarName} for integration ${integrationId}`
);
} catch (error) {
Expand Down Expand Up @@ -194,11 +210,6 @@ export class SqlIntegrationEnvironmentVariablesProvider implements ISqlIntegrati
if (metadata && typeof metadata === 'object') {
const integrationId = (metadata as Record<string, unknown>).sql_integration_id;
if (typeof integrationId === 'string') {
// Skip the internal DuckDB integration
if (integrationId === DATAFRAME_SQL_INTEGRATION_ID) {
continue;
}

integrationIds.add(integrationId);
logger.trace(
`SqlIntegrationEnvironmentVariablesProvider: Found integration ${integrationId} in cell ${cell.index}`
Expand Down
10 changes: 8 additions & 2 deletions src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
assert.deepStrictEqual(envVars, {});
});

test('Skips internal DuckDB integration', async () => {
test('Returns environment variable for internal DuckDB integration', async () => {
const uri = Uri.file('/test/notebook.deepnote');
const notebook = createMockNotebook(uri, [
createMockCell(0, NotebookCellKind.Code, 'sql', 'SELECT * FROM df', {
Expand All @@ -75,7 +75,13 @@ suite('SqlIntegrationEnvironmentVariablesProvider', () => {
when(mockedVSCodeNamespaces.workspace.notebookDocuments).thenReturn([notebook]);

const envVars = await provider.getEnvironmentVariables(uri);
assert.deepStrictEqual(envVars, {});

// Check that the environment variable is set for dataframe SQL
assert.property(envVars, 'SQL_DEEPNOTE_DATAFRAME_SQL');
const credentialsJson = JSON.parse(envVars['SQL_DEEPNOTE_DATAFRAME_SQL']!);
assert.strictEqual(credentialsJson.url, 'deepnote+duckdb:///:memory:');
assert.deepStrictEqual(credentialsJson.params, {});
assert.strictEqual(credentialsJson.param_style, 'qmark');
});

test('Returns environment variable for PostgreSQL integration', async () => {
Expand Down