Skip to content

Conversation

@saltenasl
Copy link
Member

@saltenasl saltenasl commented Nov 12, 2025

Snowflake username&password authentication method was broken. It was fixed upstream in @deepnote/database-integrations, so this is just a simple bump.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest compatible versions for improved stability and performance.

@saltenasl saltenasl requested a review from a team as a code owner November 12, 2025 12:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

📝 Walkthrough

Walkthrough

The @deepnote/database-integrations dependency in package.json is updated from version ^1.1.1 to ^1.3.0. This allows the package to consume versions up to 1.3.x of the dependency within the semantic versioning constraint. No other files or functional code changes are present.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title directly matches the main change: bumping @deepnote/database-integrations to 1.3.0 to fix Snowflake authentication.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b9a2957 and dd60c76.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

2482-2482: Dependency bump addresses stated issue — verify test coverage.

The caret constraint remains consistent with the prior approach, and the minor version bump (1.1.1 → 1.3.0) follows semver conventions. This should pick up the Snowflake auth fix from upstream.

Ensure CI tests pass with this new dependency to catch any unexpected incompatibilities at runtime. While a minor version bump shouldn't break anything, it's worth confirming the Snowflake authentication flow works end-to-end.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73%. Comparing base (b9a2957) to head (dd60c76).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #200   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        577     577           
  Lines      47663   47663           
  Branches    5597    5597           
=====================================
  Hits       34939   34939           
  Misses     10887   10887           
  Partials    1837    1837           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@saltenasl saltenasl merged commit fcfd118 into main Nov 12, 2025
13 checks passed
@saltenasl saltenasl deleted the ls/fix-snowflake-password-auth branch November 12, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants