Raise a PipelineWrapperError if run_api or run_api_async have no return type
#152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have something like:
So no defined return type for
run_api. Currently this is unhandled in Hayhooks (deploy fails since it cannot dynamically create a response model).The idea is instead to return an error with this message:
Pipeline wrapper is missing a return type for 'run_api' method.Note that in FastAPI it's not mandatory to have a Pydantic model for response, but generally it's highly recommended and will improve DX and docs.