feat: Add Together AI integration #2268
Conversation
github-actions
bot
added
topic:CI
type:documentation
Amnah199
changed the title
Generator and ChatGenerator
There was a problem hiding this comment.
Looks quite good to me already! I have a couple of change requests, most of them with suggestions of code changes. In addition, the repo README should list the integration https://github.com/deepset-ai/haystack-core-integrations/blob/main/README.md
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
integrations/together_ai/tests/test_together_ai_chat_generator.py
Outdated
Show resolved
Hide resolved
...rations/together_ai/src/haystack_integrations/components/generators/together_ai/generator.py
Outdated
Show resolved
Hide resolved
...rations/together_ai/src/haystack_integrations/components/generators/together_ai/generator.py
Outdated
Show resolved
Hide resolved
...rations/together_ai/src/haystack_integrations/components/generators/together_ai/generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Show resolved
Hide resolved
|
Sorry for all the baseless typos in this PR! Will request review again once I have tested the component in deepset platform. |
| tools: Optional[Union[List[Tool], Toolset]] = None, | ||
| timeout: Optional[float] = None, | ||
| max_retries: Optional[int] = None, | ||
| http_client_kwargs: Optional[Dict[str, Any]] = None, |
There was a problem hiding this comment.
Wondering whether we need this param http_client_kwargs here. Its compatible but not sure if it adds any value for this integration.
There was a problem hiding this comment.
Makes sense to me to have it so that http client settings can be passed on to the OpenAIChatGenerator and I see verify=False in the example to disable ssl verification.
|
@julian-risch I tested this component as a custom component in a dc pipeline and it works. Would be nice to have another pass for the review. |
| tools: Optional[Union[List[Tool], Toolset]] = None, | ||
| timeout: Optional[float] = None, | ||
| max_retries: Optional[int] = None, | ||
| http_client_kwargs: Optional[Dict[str, Any]] = None, |
There was a problem hiding this comment.
Makes sense to me to have it so that http client settings can be passed on to the OpenAIChatGenerator and I see verify=False in the example to disable ssl verification.
Related Issues
Proposed Changes:
Add a new integration for TogetherAI that inherits from
OpenAIChatGeneratorHow did you test it?
Add new tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.