Update admin.py #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Django no-longer include `update_wrapper`, as it's expected to be provided in the language's standard library.
Here's the error I was getting as of now:
File "/usr/lib/python2.7/site-packages/singleton_models/admin.py", line 5, in <module>
from django.utils.functional import update_wrapper
ImportError: cannot import name update_wrapper
My environment is: Django 1.6.2 final, and Python 2.7.6
Owner
|
Hi there, thanks very much for the Pull Request! I need to test to make sure this change is backwards compatible, back to Django 1.3, before accepting. |
defbyte
added a commit
that referenced
this pull request
Mar 24, 2014
Newer versions of Django no-longer include `update_wrapper`, as it's expected to be provided in the language's standard library. Thanks to @mcnemesis
Owner
|
Update version tagged (0.1.8) and pushed to Pypi: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Django no-longer include
update_wrapper, as it's expected to be provided in the language's standard library.Here's the error I was getting as of now:
My environment is: Django 1.6.2 final, and Python 2.7.6