Update admin.py compatibility with Django 1.6 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed defaults parameter in get_urls method that crashes the SingletonModelAdmin Class
Owner
|
Hi @javiercf , thanks for submitting the pull request! We need to make sure we maintain backwards compatibility, as there are a few legacy projects that use this package which are stuck on older version of Django (one of which is on Django 1.3.x). Perhaps with a simple |
added an ImportError check to maintain backwards compatibility
Author
|
hey @defbyte you're totally right, I just added the |
defbyte
added a commit
that referenced
this pull request
Nov 5, 2014
Update admin.py compatibility with Django 1.6, maintaining backwards compatibility
Owner
|
@javiercf I'll need to update the version number, repackage, and upload to PyPi |
Owner
|
Release created and PyPi updated: https://pypi.python.org/pypi/django-singleton/0.1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed defaults parameter in get_urls method that crashes the SingletonModelAdmin Class