fix: point metal-agent mlx-server install hint at the Homebrew formula#477
Merged
Merged
Conversation
The metal-agent's "mlx-server binary not found" error and log hint told users only to pass --mlx-server-bin manually. mlx-server now ships a Homebrew formula, so the guidance leads with 'brew install defilantech/tap/mlx-server', mirroring the vllm-swift hint. The default search paths were already the Homebrew prefixes; this makes the message match reality. Also updates the MLXServerExecutor doc comment for the repo's move to the defilantech org (github.com/defilantech/mlx-server). Signed-off-by: Christopher Maher <chris@mahercode.io>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the metal-agent's
mlx-server"binary not found" guidance to lead withbrew install defilantech/tap/mlx-server, and refreshes theMLXServerExecutordoc comment for the repo's org move.Why
When the
mlx-serverruntime landed (#471),defaultMLXServerPathswas set to the Homebrew prefixes anticipating a formula that did not exist yet. The "not found" error and log hint therefore told users only to pass--mlx-server-binby hand, with no install path.mlx-servernow ships a Homebrew formula (defilantech/homebrew-tap), and the repo has moved to thedefilantechorg. The agent's guidance should reflect both.How
resolveMLXServerBinerror and themlx-server binary not foundlog hint now lead withbrew install defilantech/tap/mlx-server, then fall back to--mlx-server-bin, mirroring the existingvllm-swifthint.defaultMLXServerPathscomment notes the paths are the Homebrew prefixes. The paths themselves are unchanged, since they were already correct.MLXServerExecutordoc comment updated togithub.com/defilantech/mlx-server(the repo moved orgs; the old URL still redirects).No behavior change beyond the user-facing strings.
go build ./cmd/metal-agent/passes; no tests assert on these messages.Follow-up to #471.
Checklist
make buildpasses locally (metal-agent builds)git commit -s) per DCO